Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hydration errors caused by EnterpriseAlert #1653

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

BRKalow
Copy link
Contributor

@BRKalow BRKalow commented Feb 15, 2023

πŸ”— Relevant links

πŸ—’οΈ What

Pulls in the change made in hashicorp/react-components#881 to address hydration errors on pages that use <EnterpriseAlert inline />

🀷 Why

πŸ› οΈ How

πŸ“Έ Design Screenshots

πŸ§ͺ Testing

πŸ’­ Anything else?

@BRKalow BRKalow requested a review from a team February 15, 2023 18:42
@BRKalow BRKalow requested a review from a team as a code owner February 15, 2023 18:42
@vercel
Copy link

vercel bot commented Feb 15, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated
dev-portal βœ… Ready (Inspect) Visit Preview πŸ’¬ Add your feedback Feb 22, 2023 at 4:53PM (UTC)

@github-actions
Copy link

Some suggested prefixes and emojis that may help to write clear, actionable code review comments:

Praise πŸ™Œ Question πŸ™‹ Thought πŸ’­ Blocker 🚧 Future πŸ“Œ Optional 🎨 Nitpick ⛏️
Expand for comment prefix descriptions
Prefix+Emoji Description
Praise πŸ™Œ Use to highlight something positive. It's nice to try to leave one per review, but don't leave false praise just to leave one of these comments.
Question πŸ™‹ Use to gain clarity from the code author. The conversation could evolve into any one of these other categories. Only the reviewer should resolve these comment threads.
Thought πŸ’­ Use to share context, leave a breadcrumb, or share an idea that came up while reviewing.
Blocker 🚧 Use to request changes that block merging the current PR. Only the reviewer should resolve these comment threads.
Future πŸ“Œ Use to request changes that the code author can choose to address in the current PR or a follow-up one.
Optional 🎨 Use to suggest optional changes that you feel strongly about but ultimately defer to the code author to make a decision on. These can be comments that turn into valuable conversation starters for adopting new code styles, guidelines, or team practices.
Nitpick ⛏️ Use to suggest changes based on loose opinions or personal preferences. The difference between this and Optional 🎨  is how strong the code reviewer's opinion is.

@github-actions
Copy link

github-actions bot commented Feb 15, 2023

πŸ“¦ Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action πŸ€–

This PR introduced no changes to the javascript bundle πŸ™Œ

@BRKalow BRKalow merged commit 6a87bc8 into main Feb 22, 2023
@BRKalow BRKalow deleted the brk.fix/enterprise-alert-hydration-errors branch February 22, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants