[QTI-284] Allow complex provider configuration #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies how we decode and store provider information passed into from the scenario. Before we would only allow attributes, now we allow any number of attributes and blocks. * Create a schemaless block type to handle decoding blocks that have unknown schema. * Update provider decoder to use a schemaless block for its configuration. * Add kubernetes transport support to enos-provider decoder * Add acceptance test for generation * Update the generator to support schemaless blocks in the provider Signed-off-by: Ryan Cragun <me@ryan.ec>
ryancragun
added
the
changelog/feat
Signed-off-by: Ryan Cragun <me@ryan.ec>
ryancragun
commented
Jul 13, 2022
mikebaum
approved these changes
Jul 14, 2022
| ssh, ok := trans.AsValueMap()["ssh"] | ||
| if !ok { | ||
| // We're done, we're not going to do anything else with k8s |
| return diags | ||
| } | ||
|
|
||
| if ssh.IsNull() || !ssh.IsWhollyKnown() || !ssh.CanIterateElements() { | ||
| return diags | ||
| } | ||
|
|
||
| // We have an ssh transport. Make sure any of the paths that we've been |
There was a problem hiding this comment.
Not a big deal, just a question, Why do we validate the transport provider here? Isn't it enough that the enos-provider does that? If we change the transport we'll need to update this.
| s.Type = block.Type | ||
| s.Labels = block.Labels | ||
|
|
||
| // We need to cast this to an hclsyntax body to get access to the blocks. |
There was a problem hiding this comment.
Ah, when I was looking at the code, this is the magic I was missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies how we decode and store provider information passed
into from the scenario. Before we would only allow attributes, now we
allow any number of attributes and blocks.
unknown schema.
configuration.
Signed-off-by: Ryan Cragun me@ryan.ec
Checklist