Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build updates #212

Merged
merged 7 commits into from
Jun 7, 2019
Merged

Build updates #212

merged 7 commits into from
Jun 7, 2019

Conversation

eikenb
Copy link
Contributor

@eikenb eikenb commented Jun 7, 2019

Various updates to the Makefile and Docker builds.

@eikenb eikenb requested review from a team June 7, 2019 02:20
@eikenb eikenb added this to the 0.8 milestone Jun 7, 2019
pearkes
pearkes approved these changes Jun 7, 2019
View reviewed changes
Copy link

@pearkes pearkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good a minor comment but not blocking.

Makefile Show resolved Hide resolved
@eikenb
Copy link
Contributor Author

eikenb commented Jun 7, 2019

force push was to rebase with circleci changes

@pearkes
Copy link

pearkes commented Jun 7, 2019

Still looks good on my end.

@eikenb eikenb merged commit 087c672 into master Jun 7, 2019
@eikenb eikenb deleted the build-updates branch June 7, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearkes pearkes pearkes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eikenb @pearkes