Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change whitelist/blacklist to allowlist/denylist #246

Merged
merged 1 commit into from Aug 19, 2020
Merged

Conversation

findkim
Copy link
Contributor

@findkim findkim commented Aug 18, 2020

Updates envconsul to use inclusive language while keeping backward compatibility for the changed configuration option names. Configuration documentation, inline documentation, and variable names are updated to have minimal occurrences of the renamed values.

  • exec.env.blacklist is renamed to exec.env.denylist
  • exec.env.whitelist is renamed to exec.env.allowlist

We encourage practitioners to update their configuration to match these changes, but existing configurations are still backward compatibile.

Resolves #243

@findkim findkim requested a review from a team August 18, 2020 22:43
@findkim
Copy link
Contributor Author

findkim commented Aug 18, 2020

This PR is currently pointed to rm-vault-grace branch until #245 is merged since this also requires CT dependency update to v0.25.1.

TODO: point PR to master once #245 is merged.

Copy link
Contributor

@eikenb eikenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More great work. Thanks and LGTM!

Base automatically changed from rm-vault-grace to master August 19, 2020 20:45
@findkim findkim merged commit b2cdbe7 into master Aug 19, 2020
@findkim findkim deleted the rename-config-opt branch August 19, 2020 20:47
@eikenb eikenb added this to the 0.11.0 milestone Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace whitelist/blacklist terminology with allowlist/denylist
3 participants