New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of-watchdog http mode (status code) #67

Closed
acornies opened this Issue Jan 7, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@acornies
Copy link
Collaborator

acornies commented Jan 7, 2019

What are the steps to reproduce this issue?

  1. Build and or deploy a function that uses of-watchdog in the image (tested with powershell-http)
  2. Invoke a function that expects a response code other than 200
  3. Check the gateway response code

What happens?

faas-nomad returns the default http response writer status code (200) instead of honoring the function status code itself.

What were you expecting to happen?

faas-nomad returns status code of upstream function

Any logs, error output, etc?

curl -i -XPOST -d 'this is a curl test' -H 'Custom-Header_Andrew: cat' http://192.168.50.2:8080/function/powershell-example
HTTP/1.1 200 OK
Content-Length: 75
Content-Type: text/plain; charset=utf-8
Date: Mon, 07 Jan 2019 17:47:35 GMT
Server: Microsoft-NetCore/2.0
X-Call-Id: 11ddf5d5-5bfe-4f59-83d3-2cfa289d28d3
X-Duration-Seconds: 0.004418
X-Start-Time: 1546883255454259180

Hello! Your input was: this is a curl test with alternate http status201int

Any other comments?

Adding this for tracking. Will open a PR for it shortly.

What versions of software are you using?

Operating System: Ubuntu 16.04 x64

OpenFaaS Version: 0.9.11

Nomad Version: 0.8.6

nicholasjackson added a commit that referenced this issue Jan 9, 2019

Merge pull request #68 from acornies/feature/ofwatchdog_support
Added of-watchdog http mode support (for #67):
@nicholasjackson

This comment has been minimized.

Copy link
Collaborator

nicholasjackson commented Jan 9, 2019

Hey @acornies sorry for the delay, just merged all of your PRs and built a new image v0.3.6

Kind regards,

Nic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment