This repository has been archived by the owner on Mar 18, 2021. It is now read-only.
[WIP] Issue 25 #49
Closed
[WIP] Issue 25 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luster_id to nats args
Added a create constraints to parse the constraints slice Updated create datacenters to just accept a string from the constraints Signed-off-by: Charlie Pitkin <charlie.pitkin@gmail.com>
|
I also just noticed I need to squash and rebase. I'll do that here in the next day or so. |
|
Looks like this is still unfinished? Should probably not open a PR unless |
|
@acornies No worries. Thanks for making the update. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nicholasjackson @acornies Can I get a check of my implementation. The implementation details are in Issue #25. I am having an issue setting up the tests to work with the new format. If either of you could make some suggestions on where I am going wrong that would be great.