Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a git-ref parameter to specify checkout git reference #26

Merged
merged 4 commits into from
Jan 6, 2023
Merged

Conversation

SBGoods
Copy link
Contributor

@SBGoods SBGoods commented Nov 29, 2022

What?
This changes adds an optional git-ref parameter to both the Community and Hashicorp versions of the action. This allows users to optionally specify a specific branch, tag or SHA to checkout when using the Checkout Github Action. If this parameter is not used then the default behavior of using the reference or SHA that triggered the event or the default branch will be used.

Why?
This parameter is useful for release workflows that push changes to the repository and want to use this action in the same workflow. Since the default behavior is using the reference or SHA that triggered the workflow, if there is a change made to the remote during the workflow, it will not be captured during the checkout in this release action.

Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, @SBGoods -- two minor adjustments and we should be able to get this in. 👍

.github/workflows/community.yml Outdated Show resolved Hide resolved
.github/workflows/hashicorp.yml Outdated Show resolved Hide resolved
Co-authored-by: Brian Flad <bflad417@gmail.com>
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀 I'll get @v2 updated with this change and #25 post-merge.

@bflad bflad added this to the v2.2.0 milestone Jan 6, 2023
@bflad bflad merged commit 7b2f6c6 into main Jan 6, 2023
@bflad bflad deleted the add-git-ref branch January 6, 2023 15:33
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants