Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth: get the default subscription ID when using Azure CLI #319

Merged
merged 2 commits into from
Feb 17, 2023
Merged

Auth: get the default subscription ID when using Azure CLI #319

merged 2 commits into from
Feb 17, 2023

Conversation

manicminer
Copy link
Member

No description provided.

@manicminer manicminer requested a review from a team as a code owner February 17, 2023 12:21
tombuildsstuff
tombuildsstuff approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of comments around naming to highlight this is the default subscription id but otherwise 👍

@manicminer manicminer mentioned this pull request Feb 17, 2023
Merged
@manicminer manicminer added the release-once-merged The SDK should be released once this PR is merged label Feb 17, 2023
@github-actions github-actions bot removed the release-once-merged The SDK should be released once this PR is merged label Feb 17, 2023
@manicminer manicminer added the release-once-merged The SDK should be released once this PR is merged label Feb 17, 2023
@tombuildsstuff tombuildsstuff merged commit 76bb615 into main Feb 17, 2023
@tombuildsstuff tombuildsstuff deleted the auth/azurecli-scrape-subscription-id branch February 17, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
release-once-merged The SDK should be released once this PR is merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manicminer @tombuildsstuff