implement order preserving apis #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by #11 but altered for a few reasons: 1. I didn't want to change the API 2. When deduplicating keys #11 chose to keep the first position the key occurred at while I chose to keep the last so that the position of the key corresponds to the position of its value. 3. I added some benchmarks to ensure the technically quadratic ordered implementation wasn't pathologically slower than the linear implementation. The benchmarks show the ordered implementation to be faster for my synthesized "little" and "big" datasets: ``` BenchmarkLittle/Parse-20 284787 3960 ns/op BenchmarkLittle/ParsePairs-20 320619 3555 ns/op BenchmarkBig/Parse-20 1 1996228538 ns/op BenchmarkBig/ParsePairs-20 1 1900769619 ns/op ```
ysmood
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #11 but altered for a few reasons:
The benchmarks show the ordered implementation to be faster for my synthesized "little" and "big" datasets: