Add new ServiceAccountCredentialsTemplate, mark ServiceAccountTemplate as deprecated #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catsby
changed the title
catsby
force-pushed
the
service-account-update
branch
from
8c89e3d
to
7128e4e
Compare
calvn
reviewed
Apr 26, 2021
calvn
previously approved these changes
Apr 26, 2021
Co-authored-by: Calvin Leung Huang <1883212+calvn@users.noreply.github.com>
calvn
approved these changes
Apr 26, 2021
This was referenced Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IAM API is deprecating its
SignJwtandSignBlobendpoints.This PR updates the
ServiceAccountTemplatetemplate to make note of that, and adds a new template string to use,ServiceAccountCredentialsTemplate.Alternatively we could just update the
ServiceAccountTemplateinstead of addingServiceAccountCredentialsTemplate, however, I felt this was a cleaner and more explicit path forward.See also: hashicorp/vault-plugin-auth-gcp#108
Note: The changes to
go.sumreflect ago mod tidyoperation; I get the same changes if I run that on themasterbranch