Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix travis setup to work with go modules #19

Closed
wants to merge 1 commit into from
Closed

Fix travis setup to work with go modules #19

wants to merge 1 commit into from

Conversation

joac
Copy link

@joac joac commented Oct 25, 2018

@joac joac changed the title Require golang 1.11 on travis, to make go.mod work Fix travis setup to work with go modules Oct 25, 2018
@hoenirvili
Copy link

hoenirvili commented Mar 14, 2019

@joac I think you also need to sign the licence/cla agreement in order to make everything pass.

@hoenirvili
Copy link

@mitchellh Could you please review this?

@jefferai
Copy link
Member

Unfortunately we need the CLA signed before we can proceed.

@hoenirvili
Copy link

@jefferai I know this PR is old, I could sign the CLA and then open a separate PR including these changes.

@joac
Copy link
Author

joac commented Mar 19, 2019

Done, sorry for the delay

@hoenirvili
Copy link

@joac It stills says that the licence/cla is pending. Are you sure that you sign the agreement?

@joac
Copy link
Author

joac commented Mar 20, 2019 via email

@hoenirvili
Copy link

@jefferai How can this issue with the license can be resolved in order to merge this?

@jefferai
Copy link
Member

Sorry about that, I've poked the responsible people, hopefully it will be resolved on Monday

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 26, 2019

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Joaquín Sorianello seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@jfreda
Copy link
Member

jfreda commented Mar 26, 2019

👋 Hi @joac ! Can you please make sure that the email address that you used to author your PR commit is associated with your GitHub user? You might either need to add it to your GitHub email settings or rebase to create a different commit with a valid email address so the CLA check goes through. Thanks!

@joac joac closed this Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants