listener/tcp: better handling of min/max port env vars #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also related: #107 |
|
Also added the error wrapping from #110 to this PR. Apologies in advance for hijacking that PR! |
|
Hi. Is there any information then it will be merged? |
|
@briankassouf is there a target release for this fix? This issue is currently preventing people from being about to use the PKI plugins that Venafi has developed for Vault. |
briankassouf
approved these changes
May 9, 2019
This was referenced Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the case where
PLUGIN_MIN_PORTand/orPLUGIN_MAX_PORTare not set and thus treated as empty strings. In this case,strconv.ParseIntwill error and and the plugin will fail to run.This PR sets those values as 0 if not provided and lets the OS handle the port assignment (by effectively giving it an address of
127.0.0.1:0). It also handles the case where the min port might be provided as a value larger than the max port, which would skip listener instantiation and error with "Couldn't bind plugin TCP listener".Related to hashicorp/vault#6587