Provide a context for managing the lifecycle of gRPC plugins #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
approved these changes
Jan 18, 2018
jbardin
approved these changes
Jan 18, 2018
mitchellh
approved these changes
Jan 18, 2018
client.go
Outdated
| @@ -457,6 +462,8 @@ func (c *Client) Start() (addr net.Addr, err error) { | |||
|
|
|||
| // Close the logging channel since that doesn't work on reattach | |||
| close(c.doneLogging) | |||
| // Cancel the context | |||
There was a problem hiding this comment.
Nitpick to add a blank line above here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a plugin server goes away, gRPC clients will wait in the connecting and transient_failure states for some time (see https://github.com/grpc/grpc/blob/master/doc/connectivity-semantics-and-api.md). This PR provides a context to the host process that will be canceled when go-plugin detects the plugin process has exited. If the host process detects the context has been closed it can take steps to recover.