Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align ErrorPropagatedRetryPolicy with DefaultRetryPolicy #116

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Align ErrorPropagatedRetryPolicy with DefaultRetryPolicy #116

merged 2 commits into from
Nov 4, 2020

Conversation

maximerety
Copy link
Contributor

@maximerety maximerety commented Nov 3, 2020 •
edited
Loading

Fixes #117.

ErrorPropagatedRetryPolicy should have been modified in PR #100 to retry on 429 Too Many Requests errors and stay aligned with DefaultRetryPolicy (as described in the source code).

But it wasn't modified... probably because it has been merged approximately at the same time as PR #70 (the PR adding ErrorPropagatedRetryPolicy).

Note: I added a second commit to this PR to factor the portion of code that can be shared between DefaultRetryPolicy and ErrorPropagatedRetryPolicy. This could help prevent such coding errors in the future.

@maximerety
Realign behavior of ErrorPropagatedRetryPolicy with DefaultRetryPolicy
0fe0e08 
ErrorPropagatedRetryPolicy should have been modified in #100,
but failed to... probably because it has been merged approximately at the same time
as #70 (the PR adding ErrorPropagatedRetryPolicy).
@maximerety
Remove code duplication between DefaultRetryPolicy and ErrorPropagate…
c7dfb57 
…dRetryPolicy
@hashicorp-cla
Copy link

hashicorp-cla commented Nov 3, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@maximerety maximerety mentioned this pull request Nov 4, 2020
Closed
jefferai
jefferai approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@jefferai jefferai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jefferai jefferai merged commit 991b9d0 into hashicorp:master Nov 4, 2020
@maximerety maximerety deleted the align-error-propagated-retry-policy branch November 5, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferai jefferai jefferai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misalignment of ErrorPropagatedRetryPolicy and DefaultRetryPolicy
3 participants
@maximerety @hashicorp-cla @jefferai