Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new NewPooledClient for people who need keepalive #14

Closed
wants to merge 2 commits into from

Conversation

painhardcore
Copy link

A new client for retrier fo the same host with keepalive

@ryanuber
Copy link
Member

ryanuber commented May 8, 2018

Hey @painhardcore, thanks for the PR!

Cases like this are exactly why we have made the HTTPClient field public - so that any client configuration under the sun can be applied to the retrying HTTP client! For these kinds of use cases I think it's best if you create a new client and apply your specific configuration to it prior to making the first request. This keeps the API surface area of retryablehttp minimal while still allowing the flexibility you are after.

I'm going to close this for that reason, thanks again for contributing!

@ryanuber ryanuber closed this May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants