Fix linting errors

helper_test.go

@@ -1233,27 +1233,27 @@ func waitForRunLock(t *testing.T, client *Client, workspaceID string) {
 	wg.Wait()
 }
 
-func retry(f retryableFn) (interface{}, error) {
+func retry(f retryableFn) (interface{}, error) { //nolint
 	tick := time.NewTicker(tickDuration * time.Second)
-
 	retries := 0
 	maxRetries := 5
 
-	for {
-		select {
-		case <-tick.C:
-			res, err := f()
-			if err == nil {
-				return res, err
-			}
+	defer tick.Stop()
 
-			if retries >= maxRetries {
-				return nil, err
-			}
+	for range tick.C {
+		res, err := f()
+		if err == nil {
+			return res, nil
+		}
 
-			retries += 1
+		if retries >= maxRetries {
+			return nil, err
 		}
+
+		retries += 1
 	}
+
+	return nil, nil
 }
 
 func genSha(t *testing.T, secret, data string) string {

tfe.go

@@ -854,7 +854,7 @@ func checkResponseCode(r *http.Response) error {
 		return err
 	}
 
-	return fmt.Errorf(strings.Join(errs, "\n"))
+	return errors.New(strings.Join(errs, "\n"))
 }
 
 func decodeErrorPayload(r *http.Response) ([]string, error) {
@@ -863,7 +863,7 @@ func decodeErrorPayload(r *http.Response) ([]string, error) {
 	errPayload := &jsonapi.ErrorsPayload{}
 	err := json.NewDecoder(r.Body).Decode(errPayload)
 	if err != nil || len(errPayload.Errors) == 0 {
-		return errs, fmt.Errorf(r.Status)
+		return errs, errors.New(r.Status)
 	}
 
 	// Parse and format the errors.