Log the warning that agent pool cleanup failed #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonc
reviewed
May 17, 2022
| @@ -60,7 +60,7 @@ func createAgentPool(t *testing.T, client *Client, org *Organization) (*AgentPoo | |||
|
|
|||
| return pool, func() { | |||
| if err := client.AgentPools.Delete(ctx, pool.ID); err != nil { | |||
| t.Errorf("Error destroying agent pool! WARNING: Dangling resources "+ | |||
There was a problem hiding this comment.
I think we should do the same thing on org cleanup. I think this error may prevent org cleanup until org delete is async
There was a problem hiding this comment.
OK - is there a way we could confirm that?
There was a problem hiding this comment.
No, aside from seeing if we hit any new dangling resource errors without it. Over time.
brandonc
approved these changes
May 17, 2022
|
Reminder to the contributor that merged this PR: if your changes have added important functionality or fixed a relevant bug, open a follow-up PR to update CHANGELOG.md with a note on your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Log the message that the agent pool cleanup failed. The org cleanup will cleanup the agent pool, and if that fails, we rebuild everything every 24 hours. This does not need to be a test failure.
Testing plan