Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IL-678 Update image_sku #311

Merged
merged 1 commit into from
Jun 22, 2023
Merged

IL-678 Update image_sku #311

merged 1 commit into from
Jun 22, 2023

Conversation

thomashashi
Copy link
Contributor

See IL-678 and hashicorp/se-workshop-hashicat-app#7 for details

@thomashashi thomashashi requested a review from a team as a code owner June 22, 2023 20:56
Copy link
Contributor Author

@thomashashi thomashashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gcastill0 gcastill0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to change the image as well.

variable "image_offer" {
  description = "Name of the offer (az vm image list)"
  default     = "0001-com-ubuntu-server-jammy"
}

Copy link
Contributor

@gcastill0 gcastill0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My last comment should be ignore.

Ship it

@thomashashi
Copy link
Contributor Author

I think we need to change the image as well.

variable "image_offer" {
  description = "Name of the offer (az vm image list)"
  default     = "0001-com-ubuntu-server-jammy"
}

This matches what we have in the commit in se-workshop-hashicat-app - https://github.com/hashicorp/se-workshop-hashicat-app/blob/6566ea2044e5212d3602584f0e55a16f9cc4dfb6/hashicat-azure/variables.tf#L32-L50:

variable "image_publisher" {
  description = "Name of the publisher of the image (az vm image list)"
  default     = "Canonical"
}


variable "image_offer" {
  description = "Name of the offer (az vm image list)"
  default     = "0001-com-ubuntu-server-jammy"
}


variable "image_sku" {
  description = "Image SKU to apply (az vm image list)"
  default     = "22_04-LTS-gen2"
}


variable "image_version" {
  description = "Version of the image to apply (az vm image list)"
  default     = "latest"
}

@thomashashi thomashashi merged commit 719e95b into master Jun 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants