LatestVersion - use version Constraints passed in
#159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the version constraint passed into the `LatestVersion` struct to ensure the constraints are checked against the returned versions.
radeksimko
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Great catch @bjhaid !
Thank you for the the fix.
I only made a minor change to aid readability in the attached test.
radeksimko
changed the title
LatestVersion - use version Constraints passed in
|
@radeksimko thanks! When should I expect the changes in this PR be released. |
|
This has just gone out in v0.6.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the version constraint passed into the
LatestVersionstruct to ensure the constraints are checked against the returned versions.