Add a DryRun() method to agent #133
Conversation
|
|
||
| // Running healthchecks for products. We don't want to stop if any fail though. | ||
| a.l.Info("Checking product availability") | ||
| if errProductChecks := a.CheckAvailable(); errProductChecks != nil { |
There was a problem hiding this comment.
I wonder if dryrun should just check whether the required clients are installed using the products' ClientCheck commands instead of also running a healthcheck. I could see it being a bit unexpected to a user if dryrun made any outbound calls.
I know this is existing behavior, so this PR might not be the place to change it, but seeing the CheckAvailable call here reminded me of it.
There was a problem hiding this comment.
I agree that issuing http reqs does break the contract a little bit, even if it's helpful. Maybe this is our first usecase for multiple commands in hcdiag?
I could see adding:
hcdiag validate
hcdiag dryrun
hcdiag run
|
I also think we can get rid of the |
Co-authored-by: Nick Chandler <nwchandler@users.noreply.github.com>
Co-authored-by: Nick Chandler <nwchandler@users.noreply.github.com>
The dependency github.com/shirou/gopsutil/v3 is updated to address a build-time deprecation warning in MacOS Monterey (12.0) and beyond. The dependency github.com/stretchr/testify has had a patch update applied. The library github.com/hashicorp/go-multierror is no longer used and has been removed.
The original goal of this refactor was to swap out a different agent with different state for running the dryrun. However, i made the classic mistake of thinking returning an interface was a good idea -- go ensures it isn't! Instead, the simpler route is to reuse the same agent, but branch off early in the Run function to instead do DryRun things.
The benefits of this is that we're no longer checking in with the agent state for the dryrun flag throughout the Run function. It all reads a lot more linear. The tradeoff is we a bit more code repetition now.
For the most part, dryrun steps don't rely on things to occur in the main run. However, there is a workaround for copiers containing the filepath in their ID. We writing a glob character * to Agent.tmpDir dryrun so that way those IDs are valid and can be copied into filters in a real run with a specific filepath.