Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print Summary to Standard Out at end of Agent Run #141

Merged
merged 5 commits into from
Jun 17, 2022

Conversation

nwchandler
Copy link
Collaborator

This merge adds a summary report to the end of an hcdiag agent run, with the intention of making it a bit easier for users to quickly see the overall status of seekers. The report is a simple table, which includes - for each product that was part of the run - a count of successful, failed, and unknown seekers, as well as the total number of seekers.

Unlike log messages, the report goes to Standard Out, meaning the run can be piped to an output file if desired.

@nwchandler nwchandler requested a review from a team June 16, 2022 20:52
@nwchandler nwchandler self-assigned this Jun 16, 2022
Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how the table works out here, that's a nice touch. The all-caps header is good for writing to a file, but feels self-explanatory and not needed in logs. I don't feel too strongly about it, so your call if you want to leave it in.

@nwchandler
Copy link
Collaborator Author

I removed the header. I agree, it was probably unnecessary for displaying in real-time to users.

@nwchandler nwchandler merged commit 9c2dfe1 into main Jun 17, 2022
@nwchandler nwchandler deleted the nwchandler/cori-254-print-summary branch June 17, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants