Improve Handling of Commander Args with Spaces #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkcp
approved these changes
Oct 3, 2022
mkcp
reviewed
Oct 3, 2022
Co-authored-by: Kit Patella <kit@jepsen.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This intends to improve hcdiag's ability to handle commander args that include spaces in them on Linux/Unix OS's. Previously, such arguments would be inappropriately split, even if they were wrapped within single quotes, which caused the command to be unable to make sense of the arguments. A library has been included which should alleviate this issue, and tests were added around the capability.
Note that no changes are made to Windows command argument processing. The underlying mechanism for Windows command calls is done differently than *nix, so the existing behavior worked for Windows.