Enable Context Propagation from Agent to Products #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge adds a context field to Agent, which is then propagated downward to products. This sets the stage for implementation of context and timeouts/cancelation within runners. It also allows us to set custom timeouts/context within the CLI as well, by enabling custom context to be set on Agent.
Wherever exported methods/functions were updated to support context, the merge does this by migrating most logic to a "
WithContext" function and then simply wrapping it with a background context in the previously existing function. This was done intentionally to maintain backwards compatibility.Where unexported functions were updated, the function signatures were simply updated to now include a context.