Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VaultDebug Runner #265

Merged
merged 28 commits into from
Nov 18, 2022
Merged

Add VaultDebug Runner #265

merged 28 commits into from
Nov 18, 2022

Conversation

groovemonkey
Copy link
Collaborator

@groovemonkey groovemonkey commented Nov 1, 2022

vault.go is fully configurable, and exposes all of vault debug's command-line options.

It's also configurable via custom HCL config:

// produces the following vault debug command:
// vault debug -compress=true -duration=30s -interval=0m10s -logformat=standard -metricsinterval=10s -output=/vault-hcdiag/hcdiag-2022-11-03T211126Z2282457017/VaultDebug.tar.gz -target=metrics
product "vault" {
  vault-debug {
    compress = true
    interval = "0m10s"
    duration = "30s"
    targets = ["metrics"]
  }
}

Highly configurable ConsulDebug and NomadDebug runners are planned next.

@groovemonkey groovemonkey self-assigned this Nov 1, 2022
@groovemonkey groovemonkey requested a review from a team November 3, 2022 22:04
@groovemonkey groovemonkey marked this pull request as ready for review November 3, 2022 22:04
@groovemonkey groovemonkey changed the title WIP: first crack at a simple (wrapped) debug runner for Nomad, Vault, Consul SimpleDebug runner for Nomad, Vault, and Consul. Also a highly configurable VaultDebug runner. Nov 3, 2022
hcl/hcl.go Show resolved Hide resolved
product/vault.go Outdated Show resolved Hide resolved
Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya, good stuff overall! There's a lot of params needed to integrate with the debug commands but it looks like there's a solid approach taken. Before we merge into main, I have a few questions and requests for revision.

runner/debug/debug.go Outdated Show resolved Hide resolved
changelog/265.txt Outdated Show resolved Hide resolved
runner/debug/simple.go Outdated Show resolved Hide resolved
runner/debug/debug.go Outdated Show resolved Hide resolved
runner/debug/vault.go Outdated Show resolved Hide resolved
runner/debug/vault.go Show resolved Hide resolved
@groovemonkey groovemonkey changed the title SimpleDebug runner for Nomad, Vault, and Consul. Also a highly configurable VaultDebug runner. VaultDebug runner Nov 7, 2022
runner/debug/debug_test.go Outdated Show resolved Hide resolved
runner/debug/debug.go Outdated Show resolved Hide resolved
hcl/hcl.go Outdated Show resolved Hide resolved
Copy link
Contributor

@mkcp mkcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwchandler nwchandler changed the title VaultDebug runner Add VaultDebug Runner Nov 18, 2022
@nwchandler nwchandler merged commit 5d9961f into main Nov 18, 2022
@nwchandler nwchandler deleted the dcohen/debug-runners branch November 18, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants