-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VaultDebug Runner #265
Conversation
…Consul. Also some tests
…uct, break into separate function for easy testing, use a map for filter option lookup, no more capitalization correction
…ctFilterString for now
…en product and debug, generally unit and manual tests working, replace vault debug command in product with one of our new Runners
… is no longer exported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heya, good stuff overall! There's a lot of params needed to integrate with the debug commands but it looks like there's a solid approach taken. Before we merge into main, I have a few questions and requests for revision.
…case for those two options now, and for vault-debug as well
…eric string to the end of the output name
…and use os.MkdirTemp instead
… logic inside of hcdiag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vault.go
is fully configurable, and exposes all ofvault debug
's command-line options.It's also configurable via custom HCL config:
Highly configurable ConsulDebug and NomadDebug runners are planned next.