Migrate Command Runner Constructors to Use Config Objects #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwchandler
commented
Nov 10, 2022
| @@ -38,12 +38,21 @@ func (r IPTables) ID() string { | |||
|
|
|||
| func (r IPTables) Run() op.Op { | |||
| startTime := time.Now() | |||
| if r.OS == "linux" { | |||
| if r.OS != "linux" { | |||
There was a problem hiding this comment.
Unrelated to the change at hand, but this looked like a little bug that had crept in as part of a recent merge.
groovemonkey
approved these changes
Nov 11, 2022
mkcp
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge updates the Command constructors to leverage a new CommandConfig object, rather than parameters. The intention is to simplify future feature additions by limiting changes to the function signatures of these constructors.