-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename DoSync to Seq and add context + timeouts #299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments inline. I also did a quick grep on the branch and saw one other reference to DoSync in a file that wasn't changed: agent/manifest.go at line 22.
…elog note of the DoSync rename
PR up that addresses feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR moves do-sync to a file and type called Seq, introduces SeqConfig, allows for Seq to be constructed with a context, and enables the entire block to be timed out at the Seq level interrupting all runners.