decoder: Add support for Map as Constraint
#199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-expr-cons-map
branch
2 times, most recently
from
b3012b7
to
8efff12
Compare
This was referenced Feb 16, 2023
radeksimko
force-pushed
the
f-expr-cons-map
branch
from
8efff12
to
a1f6732
Compare
radeksimko
force-pushed
the
f-expr-cons-map
branch
2 times, most recently
from
2e1b681
to
b938ec7
Compare
radeksimko
force-pushed
the
f-expr-cons-map
branch
3 times, most recently
from
54e173d
to
af3e246
Compare
radeksimko
changed the title
Map as ConstraintMap as Constraint
radeksimko
force-pushed
the
f-expr-cons-map
branch
6 times, most recently
from
e06082e
to
69df3d0
Compare
radeksimko
commented
Mar 10, 2023
dbanck
approved these changes
Mar 10, 2023
|
@dbanck I have made some last minor changes around the handling of the edge cases, as previously mentioned and also fixed one minor bug I found while working on that. PTAL |
15 tasks
This aligns with our design decision in List/Set/Tuple and makes the behaviour consistent + implementation slightly simpler.
radeksimko
force-pushed
the
f-expr-cons-map
branch
from
037e9b8
to
d6c0804
Compare
dbanck
approved these changes
Mar 13, 2023
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of hashicorp/terraform-ls#496
Existing tests were updated as part of ddf691a (not part of this PR) and yield either comparable or better results, except for reference collection, which:
UX