Fix LocalAddr
creation in target collection for JSON files
#202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, we create local addresses with
nil
steps, and the LS crashes when iterating over those. This PR aims to fix that.We don't get a body range for JSON-based configuration files, so we can never set the
TargetableFromRangePtr
for collected targets.hcl-lang/decoder/reference_targets.go
Lines 687 to 689 in 4804a1c
Without this pointer, we can't build a local address. So instead of trying to be clever and set a specific length, we now create all local addresses with a zero length.
Fixes hashicorp/vscode-terraform#1338
Fixes hashicorp/terraform-ls#1157