Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on prefix completion #275

Merged
merged 2 commits into from
May 11, 2023
Merged

Fix crash on prefix completion #275

merged 2 commits into from
May 11, 2023

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented May 10, 2023

This PR fixes some crashes that could occur when completing expressions with a prefix that contains a ..

It's most apparent when a user tries to complete an attribute with a boolean constraint.
2023-05-11 12 11 03

But also when accidentally typing a . when completing a Keyword, LiteralType, or LiteralValue, the crash occurs.

@dbanck dbanck added the bug Something isn't working label May 10, 2023
@dbanck dbanck self-assigned this May 10, 2023
@dbanck dbanck marked this pull request as ready for review May 11, 2023 10:16
@dbanck dbanck requested a review from a team as a code owner May 11, 2023 10:16
@dbanck dbanck merged commit 6430b42 into main May 11, 2023
4 checks passed
@dbanck dbanck deleted the b-prefix-completion-crash branch May 11, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants