Improve traversal completion for lists, tuples, and sets #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
LGTM, small nitpick: I'd replace the OneOf with the actual type in tests since it should have no impact on what's being tested.
Also if we can either address or ticket out the other types like tuple, object and map (or confirm they're not impacted) that would be great.
dbanck
changed the title
|
I fixed the issues for tuples and found out that maps and objects are also affected. But we already track these in #280 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the partial traversal completion within lists, tuples, and sets by recovering the trailing dot.
Since I recently worked on this for template expressions, I thought I could fix it for lists, tuples, and sets as well.
UX Before
UX After
Closes hashicorp/vscode-terraform#1624