Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hclsyntax: Report correct Range.End for FunctionCall w/ incomplete arg #588

Merged
merged 1 commit into from Feb 10, 2023

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Feb 9, 2023

Closes #582

Passing tests suggest this isn't breaking anything else, but I'm open to suggestions for any more (careful) changes to avoid any unforeseen consequences.

@apparentlymart apparentlymart requested a review from a team February 9, 2023 16:18
@radeksimko radeksimko force-pushed the b-fix-func-closetok-parsing branch 4 times, most recently from c01356e to 85634f7 Compare February 10, 2023 13:45
Copy link
Member

@alisdair alisdair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to usefully review the parser_test changes, but the change to parser.go seems logical to me.

@radeksimko radeksimko merged commit 67041cc into main Feb 10, 2023
@radeksimko radeksimko deleted the b-fix-func-closetok-parsing branch February 10, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect range for FunctionCallExpr w/ incomplete ObjectConsExpr inside
2 participants