Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade go 1.18 #106

Merged
merged 4 commits into from
Aug 16, 2022
Merged

Upgrade go 1.18 #106

merged 4 commits into from
Aug 16, 2022

Conversation

bcmdarroch
Copy link
Contributor

🛠️ Description

Upgrades the SDK to go version 1.18.

🚢 Release Note

Release note for CHANGELOG:

* provider: upgrade to 1.18 [GH-nnnn]

👍 Definition of Done

unit tests pass! 🎉

ok  	github.com/hashicorp/hcp-sdk-go/cmd/transform-swagger	0.414s
ok  	github.com/hashicorp/hcp-sdk-go/config	0.870s
ok  	github.com/hashicorp/hcp-sdk-go/httpclient	0.677s
ok  	github.com/hashicorp/hcp-sdk-go/resource	1.002s

itsjaspermilan
itsjaspermilan approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@itsjaspermilan itsjaspermilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bcmdarroch bcmdarroch merged commit a341831 into main Aug 16, 2022
@bcmdarroch bcmdarroch deleted the upgrade-go-1.18 branch August 16, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsjaspermilan itsjaspermilan itsjaspermilan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bcmdarroch @itsjaspermilan