Skip to content

Commit

Permalink
Do not fail a deployment when nodes have been filtered during eval.
Browse files Browse the repository at this point in the history
Previously if an eval included information about filtered nodes
the deployment would show as failed even if the non-filtered evals
placed successfully. This change means Levant will not fail when
evals are filtered and will continue to track the rest of the
deployment.

Closes #220
  • Loading branch information
jrasell committed Jul 21, 2018
1 parent 2cfd453 commit 021cdbe
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions levant/deploy.go
Original file line number Diff line number Diff line change
Expand Up @@ -254,8 +254,10 @@ func (l *levantDeployment) evaluationInspector(evalID *string) error {
}
}

return fmt.Errorf("evaluation %v finished with status %s but failed to place allocations",
*evalID, evalInfo.Status)
// Do not return an error here; there could well be information from
// Nomad detailing filtered nodes but the deployment will still be
// successful. GH-220.
return nil

default:
time.Sleep(1 * time.Second)
Expand Down

0 comments on commit 021cdbe

Please sign in to comment.