Merge pull request #211 from jrasell/enable_lint_check

Enable lint check during tests and fix discovered lint issues.

GNUmakefile

@@ -29,6 +29,7 @@ check: ## Run the gometalinter suite
 			--sort="path" \
 			--aggregate \
 			--disable-all \
+			--enable golint \
 			--enable-gc \
 			--enable goimports \
 			--enable misspell \

buildtime/consts.go

@@ -1,14 +1,17 @@
 package buildtime
 
+// These variables are populated by govvv during build time to provide detailed
+// version output information.
 var (
-	Version    string
 	BuildDate  string
 	GitCommit  string
 	GitBranch  string
 	GitState   string
 	GitSummary string
+	Version    string
 )
 
 const (
+	// PROGNAME is the name of this application.
 	PROGNAME = "Levant"
 )

helper/kvflag.go

@@ -13,7 +13,8 @@ func (v *Flag) String() string {
 	return ""
 }
 
-// Set takes...
+// Set takes a flag variable argument and pulls the correct key and value to
+// create or add to a map.
 func (v *Flag) Set(raw string) error {
 	idx := strings.Index(raw, "=")
 	if idx == -1 {
@@ -36,6 +37,9 @@ type FlagStringSlice []string
 func (v *FlagStringSlice) String() string {
 	return ""
 }
+
+// Set is used to append a variable file flag argument to a list of file flag
+// args.
 func (v *FlagStringSlice) Set(raw string) error {
 	*v = append(*v, raw)
 	return nil

main.go

@@ -8,8 +8,9 @@ import (
 	"github.com/mitchellh/cli"
 )
 
+// These variables are populated by govvv during build time to provide detailed
+// version output information.
 var (
-	// variables populated by govvv(1)
 	Version    = "dev"
 	BuildDate  string
 	GitCommit  string