verify job.Type isn't nil before continuing

The switch will still lead to a SEGV as the dereference is to a nil pointer. First verify that job.Type isn't nil.
hashicorp · Nov 14, 2017 · d17d302 · d17d302
1 parent f013954
commit d17d302
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/levant/deploy.go b/levant/deploy.go
@@ -47,6 +47,12 @@ func (c *nomadClient) Deploy(job *nomad.Job, autoPromote int) (success bool) {
 		return
 	}
 
+	// If job.Type isn't set we can't continue
+	if job.Type == nil {
+		logging.Error("levant/deploy: Nomad job `type` is not set. Should be set to `service`")
+		return
+	}
+
 	logging.Debug("levant/deploy: running dynamic job count updater for job %s", *job.Name)
 	if err := c.dynamicGroupCountUpdater(job); err != nil {
 		return