command: add render command #13
Conversation
|
Thanks for this @pmcatominey its awesome; I will try to find some day to take a proper look and merge/give feedback. |
command/render.go
Outdated
| flags := c.Meta.FlagSet("build", FlagSetVars) | ||
| flags.Usage = func() { c.UI.Output(c.Help()) } | ||
|
|
||
| flags.StringVar(&addr, "address", "", "") |
There was a problem hiding this comment.
I don't think we need address as the render command is not validating the job.
command/render.go
Outdated
| flags.Usage = func() { c.UI.Output(c.Help()) } | ||
|
|
||
| flags.StringVar(&addr, "address", "", "") | ||
| flags.StringVar(&log, "log-level", "INFO", "") |
There was a problem hiding this comment.
I doesn't seem like there is any logging except c.UI logs so this can be removed.
command/render.go
Outdated
| flags.StringVar(&addr, "address", "", "") | ||
| flags.StringVar(&log, "log-level", "INFO", "") | ||
| flags.StringVar(&variables, "var-file", "", "") | ||
| flags.StringVar(&outPath, "out", "-", "") |
There was a problem hiding this comment.
Could out default to "" rather than "-"?
command/render.go
Outdated
| var err error | ||
| var tpl *bytes.Buffer | ||
|
|
||
| flags := c.Meta.FlagSet("build", FlagSetVars) |
There was a problem hiding this comment.
"render" rather than "build". I will fix the error within the deploy Meta.FlagSet
pmcatominey
force-pushed
the
comand-render
branch
2 times, most recently
from
001e735
to
698bbed
Compare
| tpl = bytes.NewBuffer(src) | ||
| break |
There was a problem hiding this comment.
Removed this break as it would skip the template call which is necessary to catch any missing interpolations
| Render a Nomad job template, useful for debugging. | ||
|
|
||
| General Options: | ||
|
|
There was a problem hiding this comment.
Final thing; it looks like the Help is missing the -var-file variable description.
There was a problem hiding this comment.
Ah, must have removed that when I culled the other options.
allows testing how the template will be rendered
pmcatominey
force-pushed
the
comand-render
branch
from
698bbed
to
fd95da4
Compare
|
Thanks very much @pmcatominey |
allows testing how the template will be rendered
Fixes #9