Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a panic when running scale* deployment watcher. #253

Merged
merged 2 commits into from
Nov 5, 2018
Merged

Fix a panic when running scale* deployment watcher. #253

merged 2 commits into from
Nov 5, 2018

Commits on Nov 5, 2018

  1. Fix a panic when running scale* deployment watcher. 

    This fixes an issue where the client portion of the deployment
config was not being set, meaning attempts to set the watcher
query options where causing a NPE. This change fixes that and
ensures the scale out commands are using config more inline with
the rest of the commands.

Closes #251
    @jrasell
    jrasell committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    463be4d View commit details
    Browse the repository at this point in the history

  2. Also commit scale_test.go fixes based on previous commit.

    @jrasell
    jrasell committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    9f5a9f7 View commit details
    Browse the repository at this point in the history