Fix deploy loop bug when evaluation didn't include a deployment ID. #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In situations where the deployed evaluations didn't invoke a deployment, the return from the Nomad eval endpoint would include an empty deployment ID. Levant would continue to retry until the deployment ID object was populated, which possibly wouldn't happen causing Levant to get stuck in a loop forever. This change adds a timeout into the function which performs the above work, so that if after 60s no deployment ID has been returned, Levant will exit with a useful message. Closes #263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In situations where the deployed evaluations didn't invoke a
deployment, the return from the Nomad eval endpoint would include
an empty deployment ID. Levant would continue to retry until the
deployment ID object was populated, which possibly wouldn't
happen causing Levant to get stuck in a loop forever.
This change adds a timeout into the function which performs the
above work, so that if after 60s no deployment ID has been
returned, Levant will exit with a useful message.
Closes #263