Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

levant: fix infinite loop with sleep #43

Merged
merged 1 commit into from Nov 23, 2017
Merged

levant: fix infinite loop with sleep #43

merged 1 commit into from Nov 23, 2017

Conversation

pmcatominey
Copy link
Contributor

evaluationInspector only fetched the evaluation from the API once
as the call was outside of the loop

evaluationInspector only fetched the evaluation from the API once
as the call was outside of the loop
@pmcatominey
Copy link
Contributor Author

I'm still testing this, but it's a pretty simple fix

@jrasell
Copy link
Member

jrasell commented Nov 23, 2017

Thanks @pmcatominey; once the tests have completed I will get this in.

@jrasell jrasell merged commit 2690f0c into hashicorp:master Nov 23, 2017
@pmcatominey
Copy link
Contributor Author

Rebuilt from our fork and tested a deployment, no changes were made as part of the deployment but was enough to show the evaluation inspector is running.

[INFO] levant/command: running canary-auto-update of 60s
[INFO] levant/deploy: using dynamic count 2 for job xxxxxx and group xxxxxx
[INFO] levant/deploy: using dynamic count 1 for job xxxxxx and group xxxxxx
[INFO] levant/deploy: using dynamic count 1 for job xxxxxx and group xxxxxx
[INFO] levant/deploy: using dynamic count 1 for job xxxxxx and group xxxxxx
[INFO] levant/deploy: triggering a deployment of job xxxxxx
[INFO] levant/deploy: evaluation ff35264f-5a68-0b01-0ec6-20e721e14447 finished successfully
[INFO] levant/deploy: deployment e50d8778-adee-b1e2-eb8a-19d23c3bca07 has completed successfully
[INFO] levant/command: deployment of job xxxxxx successful

@pmcatominey pmcatominey deleted the eval-loop branch November 23, 2017 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants