Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return a better error when join fails #124

Merged
merged 1 commit into from Jun 22, 2017
Merged

Return a better error when join fails #124

merged 1 commit into from Jun 22, 2017

Conversation

kyhavlov
Copy link
Contributor

No description provided.

@kyhavlov kyhavlov requested a review from slackpad June 22, 2017 02:15
slackpad
slackpad approved these changes Jun 22, 2017
View reviewed changes
Copy link
Contributor

@slackpad slackpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this looks like it'll do the right thing if there's an older client in the mix as well (unknown message type error)

@kyhavlov kyhavlov merged commit 0a13646 into master Jun 22, 2017
@kyhavlov kyhavlov deleted the join-error branch June 22, 2017 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slackpad slackpad slackpad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kyhavlov @slackpad