Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through properties to top-level MDX component #292

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rfrowe
Copy link

@rfrowe rfrowe commented Aug 1, 2022

Closes #183 by fixing the props shadowing issue in scope. As was, props inside the mdx scope was being overridden by the implicit empty props passed to the top-level component for the rendered MDX. This extracts props from scope and overrides the props used on construction by wrapping the top-level component.

@hashicorp-cla
Copy link

hashicorp-cla commented Aug 1, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

props key returns empty object from scope
2 participants