Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support serializing all VFile-compatible values #311

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Support serializing all VFile-compatible values #311

merged 2 commits into from
Nov 7, 2022

Conversation

nwalters512
Copy link
Contributor

This PR adds support for serializing arbitrary VFile-compatible values, not just strings. This takes advantage of the fact that the VFile constructor supports a string, Buffer, or an existing VFile object (source).

Closes #309.

@hashicorp-cla
Copy link

hashicorp-cla commented Nov 7, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nwalters512 nwalters512 marked this pull request as ready for review November 7, 2022 05:06
@nwalters512 nwalters512 mentioned this pull request Nov 7, 2022
Closed
BRKalow
BRKalow approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@BRKalow BRKalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, thank you!

@BRKalow BRKalow merged commit f68d370 into hashicorp:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BRKalow BRKalow BRKalow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v4: Cannot provide filepath to plugins
3 participants
@nwalters512 @hashicorp-cla @BRKalow