Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

policy: autoscaler fails to canonicalize Nomad APM query with non-default plugin name #216

Closed
jrasell opened this issue Jul 13, 2020 · 0 comments · Fixed by #221
Closed

policy: autoscaler fails to canonicalize Nomad APM query with non-default plugin name #216

jrasell opened this issue Jul 13, 2020 · 0 comments · Fixed by #221
Assignees
@jrasell
Milestone
0.1.1

Comments

@jrasell
Copy link
Member

jrasell commented Jul 13, 2020

A user may wish to name their Nomad APM plugin something other than nomad-apm. Currently this will break the APM query canonicalize as the function currently exists early if source != nomad-apm.

Therefore when performing canonicalization as above, the function should have the ability to work correctly even in cases where the operators is using the non-default APM name.

cc @eveld
@jrasell jrasell added this to the 0.1.1 milestone Jul 13, 2020
@jrasell jrasell self-assigned this Jul 17, 2020
jrasell added a commit that referenced this issue Jul 17, 2020
@jrasell
changelog: add entry for GH-216 fix.
60a28ad
@jrasell jrasell mentioned this issue Jul 17, 2020
Merged
jrasell added a commit that referenced this issue Jul 20, 2020
@jrasell
Merge pull request #221 from hashicorp/gh-216
de2d6a8 
policy: fix issue when parsing non-default source name Nomad query.
@diegombeltran diegombeltran mentioned this issue Sep 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrasell jrasell

Labels
None yet
Projects
None yet
Milestone
0.1.1
Development

Successfully merging a pull request may close this issue.

policy: fix issue when parsing non-default source name Nomad query. hashicorp/nomad-autoscaler
1 participant
@jrasell