scaleutils: protect Autoscaler node from scale in. #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgbaker
approved these changes
Jul 1, 2020
Until the Nomad Autoscaler has the ability to reconcile actions which have not reached a terminal state, the scaleutils should protect the node the Nomad Autoscaler is running on from scalein actions. This gives better assurance that the autoscaler wont drain the node its on and then not be able to complete the scaling action. Even once the autoscaler has reconcile ability, there are some interesting dicussions to be had about what logic to apply in the situation where the autoscaler is running as a Nomad job and identifies its own node for scaling in. In this case, we know it will never be fully able to complete the action.
jrasell
force-pushed
the
protect-autoscaler-node-cluster-scaling
branch
from
1c7117b
to
8148308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until the Nomad Autoscaler has the ability to reconcile actions
which have not reached a terminal state, the scaleutils should
protect the node the Nomad Autoscaler is running on from scalein
actions. This gives better assurance that the autoscaler wont
drain the node its on and then not be able to complete the scaling
action.
Even once the autoscaler has reconcile ability, there are some
interesting dicussions to be had about what logic to apply in the
situation where the autoscaler is running as a Nomad job and
identifies its own node for scaling in. In this case, we know it
will never be fully able to complete the action.