Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent: add initial telemetry implementation to emit key stats for monitoring #238

Merged
merged 5 commits into from
Aug 24, 2020

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Aug 10, 2020

closes #104

Copy link
Contributor

@cgbaker cgbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

agent/http/server.go Show resolved Hide resolved
policy/file/source.go Show resolved Hide resolved
policy/manager.go Show resolved Hide resolved
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but this look great :shipit:

agent/telemetry.go Outdated Show resolved Hide resolved
agent/http/server_test.go Show resolved Hide resolved
policy/manager.go Outdated Show resolved Hide resolved
@jrasell jrasell merged commit 6f1b867 into master Aug 24, 2020
@jrasell jrasell deleted the f-gh-104 branch August 24, 2020 13:36
jrasell added a commit that referenced this pull request Aug 24, 2020
jrasell added a commit that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] emit key metrics for collection and reporting
3 participants