-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRT onboarding #582
Merged
CRT onboarding #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgfa29
force-pushed
the
crt
branch
4 times, most recently
from
May 26, 2022 00:34
2e6f80b
to
2bacb7e
Compare
lgfa29
force-pushed
the
crt
branch
3 times, most recently
from
May 26, 2022 18:46
1a12d00
to
4cd401d
Compare
The `github.event` context is not available to workflows dispatch calls, so the `repo` env var was empty. Using the `PKG_NAME` avoids this problem and also provides a more consistent artifact naming, since all other are based on this value already. GitHub release pages also render the line break in the Markdown, resulting in a weird narrow output.
DerekStrickland
approved these changes
Jun 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jazzyfresh
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the release process to use the new CRT pipeline. Apart from adding a standardized release flow, the new pipeline solves several outstanding issues.
Also standardize on some release practices, like using
make dev
instead ofmake build
and formatting HCL files on lint.Closes #88
Closes #89
Closes #304
Closes #517