make sure target is always between min and max #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgfa29
added a commit
that referenced
this pull request
May 26, 2022
lgfa29
requested review from
smacfarlane and
alvin-huang
and removed request for
a team
The current policy evaluation always attempts to query the APM for metrics and apply the policy strategy before making a scaling decision. But in some situations the target may be out of the specified min and max range from the beginning. In these situations, we would want to correct the target first so it's in within the expected range before applying the rest of the policy. This change short-circuits the most the policy evaluation if the target count status is outside this range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current policy evaluation always attempts to query the APM for
metrics and apply the policy strategy before making a scaling decision.
But in some situations the target may be out of the specified min and
max range from the beginning. In these situations, we would want to
correct the target first so it's in within the expected range before
applying the rest of the policy.
This change short-circuits the most the policy evaluation if the target
count status is outside this range.
Closes #577