Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver is not reading correct rootless info #92

Closed
silvercrown07 opened this issue Mar 9, 2021 · 2 comments · Fixed by #94
Closed

Driver is not reading correct rootless info #92

silvercrown07 opened this issue Mar 9, 2021 · 2 comments · Fixed by #94

Comments

@silvercrown07
Copy link

Hi guys, recently I have been playing with the driver quite some and found some information displayed in nomad ui incorrectly, which is the rootless attribute.

Per the current implementation, it's reading from info.Host.Rootless:

attrs["driver.podman.rootless"] = pstructs.NewBoolAttribute(info.Host.Rootless)

However I think it should be host.security.rootless per the podman's documentation: https://docs.podman.io/en/latest/_static/api.html#operation/libpodGetInfo

Please let me know if I got things wrong, and thank you for this awesome driver!

@towe75
Copy link
Collaborator

towe75 commented Mar 10, 2021

Hi @silvercrown07 , thank you for the report.
Probably it's a podman 3.x change.
I'll have a look.

@silvercrown07
Copy link
Author

silvercrown07 commented Mar 11, 2021

After some digging i think i found the source: containers/podman@04b43cc libpod/define/info.go

And yes it's a podman 3.x change

towe75 added a commit that referenced this issue Mar 21, 2021
fix #92 parse rootless info correctly from podman 3.0.x struct
fix #93 use slirp4netns as default network mode if running rootless
Bump supported podman version in README to 3.0.x
towe75 added a commit that referenced this issue Mar 22, 2021
fix #92 parse rootless info correctly from podman 3.0.x struct
fix #93 use slirp4netns as default network mode if running rootless
Bump supported podman version in README to 3.0.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants