chore: use error context to log errors rather than Go err style. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasell
force-pushed
the
b-use-error-log-context
branch
from
5f3fd32
to
257ae90
Compare
towe75
approved these changes
Jun 17, 2021
Nothing to do with hclog functionality and mostly to do with consistency. When utilising centralised log aggregation we want to ensure search and filter patterns are as easy as possible for operators. Allowing a single search of "error" across Nomad core and drivers means less overhead when creating error tracking panels. Additionally, the use of "err" is a idiomatic Go and doesn't have a common wider use. |
jrasell
added a commit
that referenced
this pull request
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.