config: Add readonly_rootfs config option like docker plugin #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabloyoyoista
requested review from
jazzyfresh,
jrasell,
lgfa29 and
towe75
as code owners
pabloyoyoista
force-pushed
the
readonly
branch
from
426823c
to
b412213
Compare
towe75
approved these changes
Oct 9, 2021
pabloyoyoista
force-pushed
the
readonly
branch
from
22fe543
to
d9bfda6
Compare
pabloyoyoista
force-pushed
the
readonly
branch
from
d9bfda6
to
c71e7bb
Compare
|
Test added and rebased on top of |
|
Is there any chance this can be merged? Or any comments/requested changes? |
|
Nope, thanks for the test! @towe75 I'm going to merge this 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the feature parity between docker and podman plugins. Nomad mounts are still successful inside the container.